Pin task version to 3.9.0 because of the PATH on win bug #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
os: windows
Codecov Report
@@ Coverage Diff @@
## main #677 +/- ##
=====================================
Coverage 8.46% 8.46%
=====================================
Files 65 65
Lines 5046 5046
=====================================
Hits 427 427
Misses 4565 4565
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
per1234
approved these changes
Nov 30, 2021
umbynos
added a commit
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Infrastructure fix
The Test Go workflow on Windows is broken after the newest release of Task (3.9.1) and was working fine with 3.9.0
The problem should be linked to the upgrade in
mvdan/shthey did in 3.9.1.The bug is present only on Windows, apparently the PATH env variable is not expanded correctly under subcommands.
To mitigate the issue, we decided to pin the task version used to 3.9.0 in the workflows
no